Fix #35 ('jQuery is not defined' when jquery_datepicker HTML output exists in the DOM before jQuery gets loaded.)#36
Open
drakmail wants to merge 2 commits intoalbertopq:masterfrom
Open
Conversation
added 2 commits
January 25, 2013 01:01
Try to fix with defer javascript loading.
With using window.onload.
Author
|
Maybe, better add parameter to helper for this case. |
Owner
|
Hey! Thanks for the contribution. Makes sense waiting for the window.onload. Could you please modify the expected output in the tests as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue with loading datepicker, when jQuery included at bottom of page (before
</body>).